-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm_minimal: add zcu102 support #46
Conversation
4e0348a
to
4b0d4d5
Compare
d6dc43b
to
98fa9c5
Compare
Changed "Test with:" form seL4/camkes-vm#111 to .../112 Since seL4/util_libs#169 and seL4/seL4#1102 have been closed, these should be removed also? |
Yes. I removed the two closed PRs from the "Test with" list. |
Can this get reviewed? |
In general, the changes look ok to me. However, I can't test this in detail. |
e83b90e
to
7fc7d7a
Compare
adda808
to
53900a5
Compare
@axel-h Can you review this PR now that the files have been merged into camkes-vm-images? I believe this is the last piece before the ZCU102 is fully supported in mainline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@abrandnewusername can this be merged after the camkes-vm PR so the ZCU102 can be officially supported upstream? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. Can you please also add the zcu102 to the list in the README
?
Absolutely! |
53900a5
to
c8adbe6
Compare
One sec - Testing locally and there's a problem with the DTB generation. I'll fix it quick |
c8adbe6
to
f6104c1
Compare
Alright, there were two problems:
But this works locally now, so it should be good to merge once I fixup the CI failure. |
Signed-off-by: Chris Guikema <[email protected]>
f6104c1
to
fa60480
Compare
Ok, happy to merge this now, and then we'll see if we can switch on CI for it. |
Test with: seL4/camkes-vm#112
Test with: seL4/camkes-vm-images#6